Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FAB-134] WS Protobuf #56

Merged
merged 34 commits into from
Oct 4, 2021
Merged

[FAB-134] WS Protobuf #56

merged 34 commits into from
Oct 4, 2021

Conversation

daystram
Copy link
Contributor

@daystram daystram commented Oct 3, 2021 •
edited

Migrate string JSON WS messages to binary Protobuf messages as an attempt to reduce network and CPU load on server and client, thus a better response time and horizontal scaling.

  • Create protos
  • Migrate fableous-fe to use protobufs
  • Migrate fableous-be to use protobufs
  • Benchmark before and after change
  • Update lint and build pipelines
  • Update deployment
  • Async WS handlers

@daystram daystram self-assigned this Oct 3, 2021
@daystram daystram changed the title WS Protobuf [FAB-134] WS Protobuf Oct 3, 2021
@daystram daystram temporarily deployed to Development October 3, 2021 14:57 Inactive
@daystram daystram temporarily deployed to Development October 3, 2021 14:57 Inactive
@daystram daystram marked this pull request as ready for review October 3, 2021 14:58
@daystram daystram temporarily deployed to Development October 3, 2021 15:00 Inactive
nicolauscg
nicolauscg reviewed Oct 4, 2021
View reviewed changes
Copy link
Member

@nicolauscg nicolauscg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partially done reviewing, managed to run it on localhost so all good.

when profiling before and after using pb, do we want to document it somewhere like in confluence? interested in how u did it and how much performance is gained

@daystram
Copy link
Contributor Author

daystram commented Oct 4, 2021

partially done reviewing, managed to run it on localhost so all good.

when profiling before and after using pb, do we want to document it somewhere like in confluence? interested in how u did it and how much performance is gained

The method is nowhere scientific and purely empirical but I'll get it documented

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@daystram daystram temporarily deployed to Development October 4, 2021 07:07 Inactive
@daystram daystram temporarily deployed to Development October 4, 2021 07:07 Inactive
@daystram daystram temporarily deployed to Development October 4, 2021 07:10 Inactive
@daystram daystram merged commit 5f5c891 into master Oct 4, 2021
@daystram daystram temporarily deployed to Development October 5, 2021 06:38 Inactive
@daystram daystram temporarily deployed to Development October 5, 2021 06:38 Inactive
@daystram daystram temporarily deployed to Development October 5, 2021 06:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolauscg nicolauscg nicolauscg approved these changes

@MichaelSudirman MichaelSudirman Awaiting requested review from MichaelSudirman MichaelSudirman is a code owner

@tianyuma1502 tianyuma1502 Awaiting requested review from tianyuma1502 tianyuma1502 is a code owner

@wahyuadt wahyuadt Awaiting requested review from wahyuadt wahyuadt is a code owner

Assignees

@daystram daystram

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@daystram @nicolauscg