[FAB-131] HIFI Gallery Tutorial #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolauscg
reviewed
Oct 8, 2021
Merged
wahyuadt
requested review from
daystram,
MichaelSudirman and
tianyuma1502
as code owners
nicolauscg
reviewed
Oct 9, 2021
There was a problem hiding this comment.
looks good! 2 minor points though
- for the first step of tutorial, do we want it to be centered or highlighting the tutorial button in navbar? what do you think? im okay for either one, but we should make it consistent with canvas tutorial, currently it highlights tutorial button, so either make the change in story detail, or change the canvas tutorial one
- in canvas tutorial, since its a page exclusively accessed by students, login and logout buttons are hidden, in story detail, I think we still show them, but add a margin to the right of the tutorial button
nicolauscg
approved these changes
Oct 9, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.