-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAB-135] Participant control #60
Conversation
daystram
commented
Oct 7, 2021
•
edited
edited
- Kick participants
- Clear controller layer
- LayerToolbar readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes looks good, I tested on localhost for the new feats this PR and ur tool improvements PR, reviewed changes line by line for this one too.
to confirm ws flow
- for clear: hub sends ws msg which BE will broadcast to student's canvas and hub layer for that role
- for kick: hub sends ws msg then BE will dc that student? if so, we can put some text on ws flow confluence page so others may be aware of this
2 minor stuff for discussion
- do we want color tool tooltip to be 1 or 2 rows? concerned of a possbile overflow if 1 row
- looks like tooltip border for both hub and student tools is hard to see when canvas is also white, do we want to try adding like a black border?
Both new WS flow appears correct, will update docs. We can have 2 rows for the colour palette and add a thin border to the tooltip. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good!