Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE-3424: Initial SDK implementation (WIP) #1

Merged
merged 1 commit into from
Jun 14, 2023
Merged

DE-3424: Initial SDK implementation (WIP) #1

merged 1 commit into from
Jun 14, 2023

Conversation

gunnarmorling
Copy link
Contributor

@gunnarmorling gunnarmorling commented Jun 7, 2023

Hey @rmetzger and @nicoweidner, this is all still very much in flux, but here's a draft PR for the upcoming SDK. It's fundamentally working, see the test for an end-to-end example. Feedback welcome, just focus on the high-level aspects at this point, polishing will come later. Thanks!

In terms of the general design, the idea is to have wrappers around Flink's Kafka source and sink, DecodableStreamSource and DecodableStreamSource; they are used like so, i.e. like any other Flink source or sink:

    DecodableStreamSource<String> source =
        DecodableStreamSource.builder()
            .withStreamName("purchase-orders")
            .build();

The topic name mappings, bootstrap servers, and any other potentially needed info is injected via env vars. Users should only ever work with the API in co.decodable.sdk; the internal package is well, internal, and mostly deals with wrapping the Kafka source and sink types (which was a PITA, but looks like I could make it work in the end).

Copy link
Contributor

@rmetzger rmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized half way through that this is a draft PR. Still posting the comments I have so far.

@gunnarmorling gunnarmorling marked this pull request as ready for review June 14, 2023 09:18
@gunnarmorling gunnarmorling merged commit 44dafa1 into main Jun 14, 2023
@gunnarmorling gunnarmorling deleted the DE-3424 branch June 14, 2023 09:18
@gunnarmorling
Copy link
Contributor Author

And applied. Thx for reviewing, @rmetzger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants