Add missing save() call at the end of open() #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If changes in self.info are done, self.save() writes them into self.oldinfo. When modifying/creating the object self.oldinfo and self.info are compared and the changes are written to LDAP. As there no save() call is done the change can't be detected. Probably open() (and therefore save()) was called mutliple times, so that this never occurred as bug and this change is not a regression. open() was e.g. called in openSuperordinate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If changes in self.info are done, self.save() writes them into
self.oldinfo.
When modifying/creating the object self.oldinfo and self.info are
compared and the changes are written to LDAP. As there no save() call is
done the change can't be detected.
Probably open() (and therefore save()) was called mutliple times, so that this never occurred as bug
and this change is not a regression.
open() was e.g. called in openSuperordinate.