Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'partly cloudy night' #662

Open
JanDetrez opened this issue Mar 31, 2024 · 3 comments · Fixed by #689
Open

Add 'partly cloudy night' #662

JanDetrez opened this issue Mar 31, 2024 · 3 comments · Fixed by #689
Assignees

Comments

@JanDetrez
Copy link

JanDetrez commented Mar 31, 2024

Is it possible to have a 'partly cloudy night' condition so we see an icon of a moon with clouds during the night, instead of the sun?

Of course, this requires the weather integration to provide this condition as well. I asked if the particular one I am using, can do this. jdejaegh/irm-kmi-ha#16

To have a generalised solution, you could also consider to have the Lovelace integration check sunrise/sundown and edit the icon accordingly even if the weather integration does not discriminate between night and day. Not sure how/if it is technically possible to do this sort of override.

As you see below, it is a bit odd that during the night we see this 'partly cloudy' condition with a sun.

Screenshot_20240331-064528

@JanDetrez
Copy link
Author

FYI in the post linked above @jdejeagh mentioned ways of solving this in the lovelace card :-) thanks for considering implementing this.

@decompil3d decompil3d self-assigned this Jun 12, 2024
decompil3d added a commit that referenced this issue Jun 12, 2024
…l/icons (#689)

* [#662] Use sun position calculations to show partly cloudy night label/icons

* [Auto] Adding updated localization files

Files changed:
M	src/localize/languages/cs.json
M	src/localize/languages/da.json
M	src/localize/languages/de.json
M	src/localize/languages/es.json
M	src/localize/languages/fr.json
M	src/localize/languages/hu.json
M	src/localize/languages/it.json
M	src/localize/languages/nb.json
M	src/localize/languages/nl.json
M	src/localize/languages/nn-NO.json
M	src/localize/languages/pl.json
M	src/localize/languages/pt-BR.json
M	src/localize/languages/pt.json
M	src/localize/languages/ru.json
M	src/localize/languages/sk.json
M	src/localize/languages/zh.json

* Calculate sunrise/set based on local time date
@decompil3d
Copy link
Owner

Reopening this since the original fix was buggy.

@decompil3d decompil3d reopened this Jun 17, 2024
@formatBCE
Copy link

formatBCE commented Jun 18, 2024

@decompil3d could that buggy fix (with sunrise/sunset usage) be the reason of #696 ? I was checking the changes between 5.4.0 and 6.0.0, and that function is the only suspicious thing (well, apart from bunch of lib updates, that could cause it of course), and since the time is also shown incorrectly for me, i thought maybe it's something with UTC/non-UTC stuff, or location settings?

P.S. actually, i see that you removed that code in 6.0.1 when disabled new changes. Let me install 6.0.1 and see if it works.

P.P.S. nope, it's some updated libs that causing it, unfortunately...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants