[fix] Bail early for negative howMany values

decompil3d · Jun 28, 2018 · 4f6ef3d · 4f6ef3d
1 parent fe168f5
commit 4f6ef3d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -18,7 +18,7 @@
  * @public
  */
 const randomFromCollection = module.exports = function randomFromCollection(collection, howMany) {
-  if (howMany === 0)
+  if (howMany < 1)
     return [];
 
   const collectionSize = typeof collection.size === 'number' ? collection.size : collection.length;

diff --git a/test.js b/test.js
@@ -14,6 +14,12 @@ describe('random-from-collection', function () {
     assume(result).has.length(0);
   });
 
+  it('returns an empty array when howMany is -1', function () {
+    const result = randomFromCollection(fixtureSet, -1);
+    assume(result).is.an('array');
+    assume(result).has.length(0);
+  });
+
   it('returns an empty array when collection is empty', function () {
     const result = randomFromCollection(new Set([]), 5);
     assume(result).is.an('array');