Switch timeout mechanism to subprocess.run
#659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay: hopefully the last timeout-related PR from me for a while :)
This PR:
timeout
argument to run_subprocess that passes through tosubprocess.run
DummyLongRunningCompiler
that does nothing but wait for an hour if invokedtest_compiler_timeout
, that sets a compilation timeout of three seconds, invokesDummyLongRunningCompiler
, and verifies a timeout error was generatedTested on both django's
runserver
and gunicorn, and verified that that a) both work happily with this timeout mechanism, and b) the impact on latency of compile calls is negligible (within the range of network jitter).(with many thanks to @simonlindholm for the methodology)