Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods in ReadYamlMapping and unit tests #78

Merged
merged 2 commits into from
Feb 28, 2017
Merged

Methods in ReadYamlMapping and unit tests #78

merged 2 commits into from
Feb 28, 2017

Conversation

amihaiemil
Copy link
Member

@amihaiemil amihaiemil commented Feb 28, 2017

PR for #73

Added OrderedYamlLines decorator, to separate concerns, because having RtYamlLines always ordering the lines is not correct; we don't always want the lines to be ordered - for instance, method ReadYamlMapping.string(YamlNode) doesn't work right if the lines are ordered.

Also, when calling ReadYamlMapping.indent() (which prints the lines), the lines should not be ordered.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.0%) to 84.762% when pulling 05ff0c7 on 73 into 05099b5 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+5.0%) to 84.762% when pulling 05ff0c7 on 73 into 05099b5 on master.

@amihaiemil
Copy link
Member Author

@SherifWaly Just for information, you can look here if you want to see why I added OrderedYamlLines

@amihaiemil
Copy link
Member Author

@rultor merge pls

@rultor
Copy link
Collaborator

rultor commented Feb 28, 2017

@rultor merge pls

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 05ff0c7 into master Feb 28, 2017
@rultor
Copy link
Collaborator

rultor commented Feb 28, 2017

@rultor merge pls

@amihaiemil Done! FYI, the full log is here (took me 1min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants