Reading of YamlStream #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amihaiemil
commented
Mar 22, 2020
pom.xml
Outdated
| @@ -140,7 +140,7 @@ | |||
| </executions> | |||
| <configuration> | |||
| <excludes> | |||
| <exclude>**/*RtYamlStreamBuilder$*.*</exclude> | |||
| <exclude>**/*YamlStream.java</exclude> | |||
There was a problem hiding this comment.
We exclude this interface from code-coverage calculation in order to avoid unit testing the default Stream methods which are just delegations.
Pull Request Test Coverage Report for Build 443
💛 - Coveralls |
|
@rultor merge it |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 2min) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #90
YamlStreamimplements default methods for the Stream APIReadYamlStreamReadYamlStream.values()with the help ofStartMarkerslines decorator