Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#600 start reading of flow-style nodes from a ReadYamlSequence #606

Merged
merged 1 commit into from Mar 18, 2024
Merged

Conversation

amihaiemil
Copy link
Member

PR for #600

Started implementing the reading of flow-style nodes from a (block) ReadYamlSequence.
At the moment, only inline flow nodes (starting at the dash) are read. Left TODOs to coved the rest of the cases.

@zoeself
Copy link
Collaborator

zoeself commented Mar 18, 2024

@amihaiemil thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@amihaiemil
Copy link
Member Author

@rultor merge it please

@rultor
Copy link
Collaborator

rultor commented Mar 18, 2024

@rultor merge it please

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@zoeself
Copy link
Collaborator

zoeself commented Mar 18, 2024

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role REV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

@rultor rultor merged commit 20e5788 into master Mar 18, 2024
@rultor
Copy link
Collaborator

rultor commented Mar 18, 2024

@rultor merge it please

@amihaiemil Done! FYI, the full log is here (took me 2min)

@amihaiemil amihaiemil deleted the 600 branch March 18, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants