Provided Organizations API. #34
Conversation
1 similar comment
|
@amihaiemil Please check this commit :) |
|
@SherifWaly I'll take a more detailed look tomorrow. Doesn't look bad, but the word is "organization", not "organisation" :D |
|
@amihaiemil I found the VersionEye API call it "organisation" but no problem I will change the name :D |
1 similar comment
There was a problem hiding this comment.
@SherifWaly Looks good! Just a few comments, and we don't need OranizationData :D
| * @todo #27:30min/DEV Provide RtOrganization as implementation and unit tests. | ||
| * The class should work with a given request and organization name. | ||
| */ | ||
| public interface Organization { |
There was a problem hiding this comment.
@SherifWaly As I see, we won't need OrangizationData, because an Oranziation will have its json behind, from which it will take the api_key, to be able to fetch its teams and projects. Since it will have its json, it will also have accessor methods for the json's attributes.
| * @throws IOException If something goes wrong when | ||
| * making the HTTP call. | ||
| */ | ||
| List<OrganizationData> about() throws IOException; |
There was a problem hiding this comment.
@SherifWaly Can you rename this method to fetch()? It's more suitable, I think :D
| public interface Organizations { | ||
|
|
||
| /** | ||
| * Info about Organizations (list of organizations you have access to). |
There was a problem hiding this comment.
@SherifWaly "Fetch the list of oranizations that the authenticated user has access to"
| List<OrganizationData> about() throws IOException; | ||
|
|
||
| /** | ||
| * Fetch a organization. |
There was a problem hiding this comment.
@SherifWaly "Fetch an organization"
1 similar comment
|
@SherifWaly nice :D |
|
@rultor merge |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 1min) |
PR for #27