Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Implemented Favorites and Favorite. #39

Merged
merged 2 commits into from
Apr 27, 2017
Merged

Implemented Favorites and Favorite. #39

merged 2 commits into from
Apr 27, 2017

Conversation

SherifWaly
Copy link
Contributor

PR for #20

@coveralls
Copy link

coveralls commented Apr 24, 2017 •
edited

Coverage Status

Coverage decreased (-16.6%) to 60.714% when pulling 648eed1 on SherifWaly:#20 into 1500253 on decorators-squad:master.

@SherifWaly
Copy link
Contributor Author

@amihaiemil Please check this commit :)

@amihaiemil
Copy link
Member

@SherifWaly I'll have a look as soon as I get some time, hopefully today :D

amihaiemil
amihaiemil reviewed Apr 27, 2017
View reviewed changes
Copy link
Member

@amihaiemil amihaiemil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SherifWaly Looks good! Just please use RtFavorites in RtUser.favorites() :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-16.6%) to 60.714% when pulling d7100a8 on SherifWaly:#20 into 1500253 on decorators-squad:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-16.6%) to 60.714% when pulling d7100a8 on SherifWaly:#20 into 1500253 on decorators-squad:master.

@amihaiemil
Copy link
Member

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 27, 2017

@rultor merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Apr 27, 2017

@rultor merge

@SherifWaly @amihaiemil Oops, I failed. You can see the full log here (spent 1min)

load average is 0.05, low enough to run a new Docker container
+ break
+ cd ..
+ '[' -n '' ']'
+ use_image=yegor256/rultor
+ docker pull yegor256/rultor
Using default tag: latest
Trying to pull repository docker.io/yegor256/rultor ... latest: Pulling from yegor256/rultor
Digest: sha256:2eb0168d7cf1e2582650a5ebc0f6dae434f2888ff246e756e7375d661d96f2ac
Status: Image is up to date for docker.io/yegor256/rultor:latest

+ docker ps --filter=status=exited
+ grep --quiet '\sdecorators-squad_versioneye-api_39\s*$'
+ ls -al .
total 36
drwx------  3 rultor rultor   84 Apr 27 12:59 .
drwxrwxrwt. 9 root   root   4096 Apr 27 12:59 ..
-rwxrwxr-x  1 rultor rultor  338 Apr 27 12:59 entry.sh
-rw-rw-r--  1 rultor rultor    4 Apr 27 12:59 pid
drwxrwxr-x  4 rultor rultor 4096 Apr 27 12:59 repo
-rwxrwxr-x  1 rultor rultor 5155 Apr 27 12:59 run.sh
-rw-rw-r--  1 rultor rultor  751 Apr 27 12:59 script.sh
-rw-rw-r--  1 rultor rultor 4931 Apr 27 12:59 stdout
++ pwd
++ pwd
+ docker run -t --rm -v /tmp/rultor-8ihS:/main '--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' --env=fork=git@github.com:SherifWaly/versioneye-api.git --env=fork_branch=#20 --env=head=git@github.com:decorators-squad/versioneye-api.git --env=head_branch=master --env=pull_id=39 '--env=pull_title=Implemented Favorites and Favorite.' --hostname=docker --privileged --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-8ihS/cid -w=/main --name=decorators-squad_versioneye-api_39 yegor256/rultor /main/entry.sh
Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.gnupg /root/.m2 /root/.npm /root/.profile /root/texmf /root/tmp /home/r
+ cp -R ./cid ./end.sh ./entry.sh ./pid ./repo ./run.sh ./script.sh ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su --login r --command /home/r/script.sh
+ set -e
+ set -o pipefail
+ shopt -s expand_aliases
+ alias 'sudo=sudo -i'
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ vars=('--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' '--env=fork=git@github.com:SherifWaly/versioneye-api.git' '--env=fork_branch=#20' '--env=head=git@github.com:decorators-squad/versioneye-api.git' '--env=head_branch=master' '--env=pull_id=39' '--env=pull_title=Implemented Favorites and Favorite.')
+ export MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g export fork=git@github.com:SherifWaly/versioneye-api.git export fork_branch=#20 export head=git@github.com:decorators-squad/versioneye-api.git export head_branch=master export pull_id=39 export pull_title=Implemented Favorites and Favorite. export vars mvn clean install -Pcheckstyle
+ MAVEN_OPTS=-XX:MaxPermSize=256m
/home/r/script.sh: line 9: export: `-Xmx1g': not a valid identifier
+ fork=git@github.com:SherifWaly/versioneye-api.git
+ fork_branch='#20'
+ head=git@github.com:decorators-squad/versioneye-api.git
+ head_branch=master
+ pull_id=39
+ pull_title=Implemented
/home/r/script.sh: line 9: export: `Favorite.': not a valid identifier
/home/r/script.sh: line 9: export: `-Pcheckstyle': not a valid identifier
container 13237faf5ab43d640cfa9889ab011849e18f662c922aff2ea5d86ec8c21b3869 is dead
Thu Apr 27 13:00:29 UTC 2017

@amihaiemil
Copy link
Member

@rultor try to merge again...

@rultor
Copy link
Collaborator

rultor commented Apr 27, 2017

@rultor try to merge again...

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Apr 27, 2017

@rultor try to merge again...

@SherifWaly @amihaiemil Oops, I failed. You can see the full log here (spent 1min)

load average is 0.05, low enough to run a new Docker container
+ break
+ cd ..
+ '[' -n '' ']'
+ use_image=yegor256/rultor
+ docker pull yegor256/rultor
Using default tag: latest
Trying to pull repository docker.io/yegor256/rultor ... latest: Pulling from yegor256/rultor
Digest: sha256:2eb0168d7cf1e2582650a5ebc0f6dae434f2888ff246e756e7375d661d96f2ac
Status: Image is up to date for docker.io/yegor256/rultor:latest

+ docker ps --filter=status=exited
+ grep --quiet '\sdecorators-squad_versioneye-api_39\s*$'
+ ls -al .
total 36
drwx------  3 rultor rultor   84 Apr 27 13:04 .
drwxrwxrwt. 9 root   root   4096 Apr 27 13:04 ..
-rwxrwxr-x  1 rultor rultor  338 Apr 27 13:04 entry.sh
-rw-rw-r--  1 rultor rultor    5 Apr 27 13:04 pid
drwxrwxr-x  4 rultor rultor 4096 Apr 27 13:04 repo
-rwxrwxr-x  1 rultor rultor 5155 Apr 27 13:04 run.sh
-rw-rw-r--  1 rultor rultor  751 Apr 27 13:04 script.sh
-rw-rw-r--  1 rultor rultor 4932 Apr 27 13:04 stdout
++ pwd
++ pwd
+ docker run -t --rm -v /tmp/rultor-ZBJz:/main '--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' --env=fork=git@github.com:SherifWaly/versioneye-api.git --env=fork_branch=#20 --env=head=git@github.com:decorators-squad/versioneye-api.git --env=head_branch=master --env=pull_id=39 '--env=pull_title=Implemented Favorites and Favorite.' --hostname=docker --privileged --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-ZBJz/cid -w=/main --name=decorators-squad_versioneye-api_39 yegor256/rultor /main/entry.sh
Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.gnupg /root/.m2 /root/.npm /root/.profile /root/texmf /root/tmp /home/r
+ cp -R ./cid ./end.sh ./entry.sh ./pid ./repo ./run.sh ./script.sh ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su --login r --command /home/r/script.sh
+ set -e
+ set -o pipefail
+ shopt -s expand_aliases
+ alias 'sudo=sudo -i'
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ vars=('--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' '--env=fork=git@github.com:SherifWaly/versioneye-api.git' '--env=fork_branch=#20' '--env=head=git@github.com:decorators-squad/versioneye-api.git' '--env=head_branch=master' '--env=pull_id=39' '--env=pull_title=Implemented Favorites and Favorite.')
+ export MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g export fork=git@github.com:SherifWaly/versioneye-api.git export fork_branch=#20 export head=git@github.com:decorators-squad/versioneye-api.git export head_branch=master export pull_id=39 export pull_title=Implemented Favorites and Favorite. export vars mvn clean install -Pcheckstyle
+ MAVEN_OPTS=-XX:MaxPermSize=256m
/home/r/script.sh: line 9: export: `-Xmx1g': not a valid identifier
+ fork=git@github.com:SherifWaly/versioneye-api.git
+ fork_branch='#20'
+ head=git@github.com:decorators-squad/versioneye-api.git
+ head_branch=master
+ pull_id=39
+ pull_title=Implemented
/home/r/script.sh: line 9: export: `Favorite.': not a valid identifier
/home/r/script.sh: line 9: export: `-Pcheckstyle': not a valid identifier
container 5f38253a8d3e9f6a53bbc1ef8bfd0e2705f1f5cea5d8a35f11fb2238ff52ed6b is dead
Thu Apr 27 13:05:27 UTC 2017

@amihaiemil
Copy link
Member

amihaiemil commented Apr 27, 2017 •
edited

@SherifWaly I'm not sure what's wrong with rultor so I'll merge it maually..

@amihaiemil amihaiemil merged commit c6fda08 into decorators-squad:master Apr 27, 2017
@SherifWaly SherifWaly deleted the #20 branch April 27, 2017 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amihaiemil amihaiemil amihaiemil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SherifWaly @coveralls @amihaiemil @rultor