Catch missed error checks

decred · Apr 19, 2016 · 82a0e17 · 82a0e17
1 parent a339852
commit 82a0e17
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/blockchain/chain.go b/blockchain/chain.go
@@ -1359,8 +1359,8 @@ func (b *BlockChain) forceHeadReorganization(formerBest chainhash.Hash,
 
 	// Child to reorganize to is missing.
 	if newBestNode == nil {
-		ruleError(ErrForceReorgMissingChild, "missing child of common parent "+
-			"for forced reorg")
+		return ruleError(ErrForceReorgMissingChild, "missing child of "+
+			"common parent for forced reorg")
 	}
 
 	newBestBlock, err := b.getBlockFromHash(&newBest)

diff --git a/blockchain/validate.go b/blockchain/validate.go
@@ -912,7 +912,7 @@ func (b *BlockChain) checkDupTxs(node *blockNode, parentNode *blockNode,
 	if err != nil {
 		str := fmt.Sprintf("Failed dup tx check of TxTreeRegular of cur "+
 			"block: %v", err.Error())
-		ruleError(ErrDuplicateTx, str)
+		return ruleError(ErrDuplicateTx, str)
 	}
 
 	return nil