blockchain: Simplify blocknode construction. #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
davecgh
force-pushed
the
blockchain_simplify_blocknode_construction
branch
2 times, most recently
from
1ce9943
to
31d500a
Compare
This separates the logic for populating the stake information in a block node from the construction of the node in order to better delineate the difference between the two and to pave the way for that information to be stored separately in the database versus needing to load full blocks to retrieve it.
This modifies the newBlockNode function to accept the parent as an argument to automatically connect the newly created node. When it is not nil, the work sum will automatically be summed and the parent of the new node will be set accordingly. This simplifies the block node construction a bit and allows some redundant code to be removed. It also paves the way for easier simpler full block index construction in the future.
davecgh
force-pushed
the
blockchain_simplify_blocknode_construction
branch
from
31d500a
to
cb40146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PR #1057.(now merged)This consists of two commits to simplify the construction logic for block nodes.
The first separates the logic for populating the stake information in a block node from the construction of the node in order to better delineate the difference between the two and to pave the way for that information to be stored separately in the database versus needing to load full blocks to retrieve it.
The second modifies the
newBlockNodefunction to accept theparentas an argument to automatically connect the newly created node. When it is notnil, the work sum will automatically be summed and the parent of the new node will be set accordingly. This simplifies the block node construction a bit and allows some redundant code to be removed. It also paves the way for easier simpler full block index construction in the future.