blockchain: Optimize reorg to use known status. #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
approved these changes
Jul 26, 2018
jrick
approved these changes
Jul 26, 2018
This optimizes the chain reorganization logic by making use of the block index status flags for known valid and invalid blocks. In particular, validation is now skipped for blocks that are either already known valid or invalid. When validating blocks, the result is stored into the block index for the block accordingly, and in the case of blocks that fail validation, all of the descendants of the invalid block are marked as having an invalid ancestor. It also introduces a new error named ErrKnownInvalidBlock which is returned in the case a forced reorg is attempted to an invalid block and adds a test to ensure it works as intended.
davecgh
force-pushed
the
blockchain_optimize_reorg_known_status
branch
from
7b0c2bd
to
46b081c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes the chain reorganization logic by making use of the block index status flags for known valid and invalid blocks.
In particular, validation is now skipped for blocks that are either already known valid or invalid. When validating blocks, the result is stored into the block index for the block accordingly, and in the case of blocks that fail validation, all of the descendants of the invalid block are marked as having an invalid ancestor.
It also introduces a new error named
ErrKnownInvalidBlockwhich is returned in the case a forced reorg is attempted to an invalid block and adds a test to ensure it works as intended.This is work towards #1145.