multi: Remove unused code. #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Oct 21, 2018
| // If height comes in at 46 we use the 35-45 window, up to height 56 etc. | ||
| // | ||
| // This function MUST be called with the chain state lock held (for writes). | ||
| func (b *BlockChain) isVoterMajorityVersion(minVer uint32, prevNode *blockNode) bool { |
There was a problem hiding this comment.
This shoudn't be removed since it's used by the tests to make sure things are working properly. It can, however, be moved to stakeversion_test.go so it is only compiled when running the tests.
davecgh
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.