mempool: Limit max vote double spends exactly. #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Feb 4, 2019
matheusd
reviewed
Feb 5, 2019
davecgh
force-pushed
the
mempool_max_double_spends
branch
from
bbc735a
to
9329edf
Compare
This modifies the check which limits the maximum allowed votes double spending the same ticket to exactly the specified constant instead of one more. It also adds tests for the max vote double spend handling to both ensure they are accepted up until the max, rejected thereafter, and that removing votes allows them to be accepted again.
davecgh
force-pushed
the
mempool_max_double_spends
branch
from
9329edf
to
98f633d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #1595.
This modifies the check which limits the maximum allowed votes double spending the same ticket to exactly the specified constant instead of one more.
It also adds tests for the max vote double spend handling to both ensure they are accepted up until the max, rejected thereafter, and that removing votes allows them to be accepted again.