main: Update for mempool/v2. #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the main module to use version 2 of the mempool module. The following is a summary of changes: - Update all imports to use mempool/v2 - Update module requirements to include new module and remove no longer needed old versions - Add an override for the v2 module so CI is always builds with the latest code - Update rpcserver getrawmempool to make use of new mempool VerboseTxDescs instead of the removed RawMempoolVerbose - Update rpcserver getrawmempool to properly return the parameter provided for the transaction type instead of the type of variable in the case an invalid type is provided - Update rpcserver getrawmempool to return the supported transaction types in the error when an invalid type is provided
jrick
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the main module to use version 2 of the mempool module.
The following is a summary of changes:
rpcservergetrawmempoolhandler to make use of newmempoolVerboseTxDescsinstead of the removedRawMempoolVerboserpcservergetrawmempoolhandler to properly return the parameter provided for the transaction type instead of the type of variable in the case an invalid type is providedrpcservergetrawmempoolto return the supported transaction types in the error when an invalid type is provided