Sync upstream through July 22, 2015 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trickling inv's to peers, allocate for the number of inv's in the queue instead of the default 1000. This should save on memory.
This commit corrects the JSON-RPC API doc return to overview links for the Websocket Extension Method Details section.
This commit correctly replaces persistent peers that are being retried in the list of persistent peers so it will continue to be retried as intended. Also, limit the maximum retry interval for persistent peers to 5 minutes. Fixes btcsuite#463.
This mimics Bitcoin Core commit a1ba0778dd3c784046dea334e5d39f37eca264f7
At the current time, there is no difference between the wire encoding at protocol version 0 and the stable long-term storage format. These methods are simply for consistency with the other types.
davecgh
changed the title
| @@ -216,14 +217,15 @@ func TestBlockHeaderWire(t *testing.T) { | |||
| continue | |||
| } | |||
|
|
|||
| b, err := wire.TstBytesBlockHeader(test.in) | |||
| buf.Reset() | |||
| err = test.in.BtcEncode(&buf, pver) | |||
There was a problem hiding this comment.
We should probably drop BtcEncode at some point for something more generic... (ccEncode??) But not a consideration for current PR.
There was a problem hiding this comment.
Yeah that would make sense. I suspect MsgEncode/MsgDecode would make the most sense given it is part of the Message interface.
|
Looks good to me. |
|
tACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.