server: Remove instead of disconnect node #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the behavior of peer disconnection logic, such that permanent peers are actually removed from the connection manager when requested, instead of just being disconnected and therefore triggering a future retry. Previously, this prevented the addnode [addr] remove from correctly removing permanent peers. A connection retry attempt would always be performed.
davecgh
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of peer disconnection logic, such that
permanent peers are actually removed from the connection manager when
requested, instead of just being disconnected and therefore triggering a
future retry.
Previously, this prevented the addnode [addr] remove from correctly
removing permanent peers. A connection retry attempt would always be
performed.
The easiest way to test this behavior is to run two nodes disconnected from any other public nodes (either in testnet or on a private simnet), connect them via
dcrctl addnode [othernode] addthen disconnect viadcrctl addnode [othernode] remove. Without this patch the nodes will reconnect, even though the previousremovecommand should have removed the peer from the permanent list.