multi: remove getblocktemplate. #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
remove_getblocktemplate
branch
2 times, most recently
from
e34fb58
to
d1f80dc
Compare
davecgh
approved these changes
Sep 5, 2019
davecgh
requested changes
Sep 5, 2019
This removes the getblocktemplate and its helpers from the codebase. Ongoing mining updates focused on the voting/block validation process with respect to generating block templates for getwork makes it the better option for decred. Also getblocktemplate rpc was buggy and has been disabled for a while. Some lint related issues have been addressed as well.
dnldd
force-pushed
the
remove_getblocktemplate
branch
from
d1f80dc
to
f8e80d8
Compare
davecgh
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
getblocktemplateand its helpers from the codebase. Ongoing mining updates focused on the voting/block validation process with respect to generating block templates forgetworkmakes it the better option for decred. Also thegetblocktemplaterpc was buggy and has been disabled for a while.The
rpc/jsonrpc/typesmodule was bumped to v2, some lint related issues have been addressed as well.Closes #130.