Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire: assert MaxMessagePayload limit in tests. #1755

Merged
merged 1 commit into from Jun 20, 2019
Merged

wire: assert MaxMessagePayload limit in tests. #1755

merged 1 commit into from Jun 20, 2019

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented May 30, 2019

This adds an additional check to tests ensuring their max payload lengths do not exceed MaxMessagePayload.

jozn
jozn reviewed Jun 12, 2019
View reviewed changes
Copy link
Contributor

@jozn jozn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codes look good, but license dates are better to be updated too.

wire/msgblock_test.go Show resolved Hide resolved
wire/msgfeefilter_test.go Show resolved Hide resolved
@dnldd
Copy link
Member Author

dnldd commented Jun 12, 2019

thanks for the review, will update soon.

@dnldd dnldd force-pushed the assert_payload_length_limit branch from c8fb867 to 3b90cbd Compare June 13, 2019 20:25
@dnldd
wire: assert MaxMessagePayload limit in tests.
04be539 
This adds an additional check to Msg tests ensuring their max
payload lengths do not exceed MaxMessagePayload.
@dnldd dnldd force-pushed the assert_payload_length_limit branch from 3b90cbd to 04be539 Compare June 13, 2019 22:08
@davecgh davecgh merged commit 3c6ff28 into decred:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jozn jozn jozn left review comments

@davecgh davecgh davecgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnldd @davecgh @jozn