secp256k1: Introduce v2 module #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Jun 14, 2019
davecgh
requested changes
Jun 15, 2019
This serves as the final release of version 1 of the dcrec/secp256k1 module. All future releases will be moving to version 2 of the module.
davecgh
approved these changes
Jun 17, 2019
davecgh
requested changes
Jun 17, 2019
There was a problem hiding this comment.
I was doing another rounds of tests to be sure and realized I approved this a bit too hastily. The schnorr package is still importing the v1 module despite being part of the v2 module. All of the imports in the schnorr/*.go files need to be updated to import "github.com/decred/dcrd/dcrec/secp256k1/v2" in the secp256k1: Introduce v2 module commit.
davecgh
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.