blockchain/standalone: Implement a new module. #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Is the plan to migrate some of the standalone funcs from the stake package in the future? |
|
I wasn't planning on doing that before the initial release, but yeah, I would like to do that eventually. |
davecgh
force-pushed
the
introduce_blockchain_standalone_module
branch
from
11ff3d8
to
b32dd61
Compare
dajohi
approved these changes
Aug 6, 2019
dnldd
approved these changes
Aug 6, 2019
matheusd
approved these changes
Aug 6, 2019
jrick
approved these changes
Aug 6, 2019
This implements a new module named blockchain/standalone which aims to provide several of the standalone functions currently available in blockchain and ultimately replace them in the next major version. The primary goal of offering these functions via a separate module is to reduce the required dependencies to a minimum as compared to the blockchain module. It will be ideal for applications such as lightweight clients that need to ensure basic security properties hold and calculate appropriate vote subsidies and block explorers. For example, some things an SPV wallet needs to prove are that the block headers all connect together, that they satisfy the proof of work requirements, and that a given transaction tree is valid for a given header. The new module currently only provides functions related to proof of work, however, future commits will provide functions for merkle root calculation, subsidy calculation, and coinbase transaction identification. It is being done in stages to help ease review since it is consensus critical code. Finally, it also includes comprehensive tests, full package documentation, and basic usage examples.
davecgh
force-pushed
the
introduce_blockchain_standalone_module
branch
from
b32dd61
to
2c7d204
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new module named
blockchain/standalonewhich aims to provide several of the standalone functions currently available inblockchainand ultimately replace them in the next major version.The primary goal of offering these functions via a separate module is to reduce the required dependencies to a minimum as compared to the
blockchainmodule. It will be ideal for applications such as lightweight clients that need to ensure basic security properties hold and calculate appropriate vote subsidies and block explorers.For example, some things an SPV wallet needs to prove are that the block headers all connect together, that they satisfy the proof of work requirements, and that a given transaction tree is valid for a given header.
The new module currently only provides functions related to proof of work, however, future commits will provide functions for merkle root calculation, subsidy calculation, and coinbase transaction identification. It is being done in stages to help ease review since it is consensus critical code.
It will not be released until the remaining functions have been implemented.
Finally, it also includes comprehensive tests, full package documentation, and basic usage examples.