multi: Explicit hash in next work diff calcs. #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
approved these changes
Dec 27, 2019
dajohi
approved these changes
Dec 27, 2019
This modifies the CalcNextRequiredDifficulty function to accept a hash instead of using the current chain tip as part of an overall effort to make the blockchain module more explicit and less reliant on the current state.
This removes the CalcNextRequiredDifficulty and CalcNextRequiredDiffNode functions, along with their associated message structs, from the block manager since they are no longer used or needed.
davecgh
force-pushed
the
blockchain_explicit_calcnextreqdiff
branch
from
2b0b963
to
e7e9052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
CalcNextRequiredDifficultyfunction inblockchainto accept a hash instead of using the current chain tip as part of an overall effort to make the blockchain module more explicit and less reliant on the current state and updates all callers accordingly. It also removes theCalcNextRequiredDiffNodewhich is no longer needed as a result as well as associated code fromblockamanager.The changes are split into multiple commits to ease the review process.