multi: Convert rpcserver lifecycle to context. #2043
Conversation
dnldd
force-pushed
the
rpcserver_use_context
branch
from
483807d
to
0e19707
Compare
dnldd
changed the title
dnldd
force-pushed
the
rpcserver_use_context
branch
from
0e19707
to
ac185e7
Compare
dnldd
force-pushed
the
rpcserver_use_context
branch
from
ac185e7
to
7b92c0c
Compare
There was a problem hiding this comment.
The overall approach looks good with the most recent iteration. Nice work so far. I did mention a final area for improvement in regards to the notifications with the inline comments as well as a couple of other very minor things.
I also manually tested the changes I recommended to the notifications via various RPC clients and the race detector to ensure the suggestion works as intended.
Finally, I gave this a thorough review and verified that there are no more call sites that are attempting to send on channels serviced by goroutines spawned by the RPC server and notification manager which aren't ultimately selecting across a channel with the context which could lead to a hang if the goroutines were to disappear out from under it.
dnldd
force-pushed
the
rpcserver_use_context
branch
from
7b92c0c
to
e8e7428
Compare
This updates the rpcserver and wsNotificationManager lifecycle processes to use a context.
dnldd
force-pushed
the
rpcserver_use_context
branch
from
e8e7428
to
fc57c94
Compare
This updates the
rpcserverandwsNotificationManagerlifecycle processes to use a context.Resolves #2037