[release-v1.5] rpcwebsocket: Use nonblocking messages and ntfns. #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All sends to channels that are serviced by separate goroutines that can be shutdown via a quit channel need to ensure they select across that quit channel when sending to the associated channel to ensure they can't end up blocking on the send during shutdown.
jrick
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #2026 to the 1.5 release branch.
All sends to channels that are serviced by separate goroutines that can be shutdown via a quit channel need to ensure they select across that quit channel when sending to the associated channel to ensure they can't end up blocking on the send during shutdown.