hdkeychain: Use direct hashes and remove dcrutil dep #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding a hash160 function with the crypto packages could make sense too, but it's so small I don't see any reason to not copy it. |
|
I'm also aware that dcrutil is still imported by test code in the hdkeychain package, but this has no effect on code importing hdkeychain, besides that it is another module version to consider when solving versions. |
This change replaces usage of chainhash (which is intended solely for transaction and blocks) and dcrutil.Hash160 (used in scripts for hashing redeem scripts and pubkeys) with direct calls to each hashing function from dcrd's crypto subpackages. This improves clarity and shortens the transitive package imports. Notably, dcrutil and everything it depends on is no longer transitively imported when importing the hdkeychain package.
davecgh
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces usage of chainhash (which is intended solely for
transaction and blocks) and dcrutil.Hash160 (used in scripts for
hashing redeem scripts and pubkeys) with direct calls to each hashing
function from dcrd's crypto subpackages. This improves clarity and
shortens the transitive package imports. Notably, dcrutil and
everything it depends on is no longer transitively imported when
importing the hdkeychain package.