secp256k1: Remove BER signature parsing. #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
approved these changes
Feb 20, 2020
This removes the ability to parse signatures encoded with the more lax Basic Encoding Rules (BER) since they have never been valid on the Decred blockchain and the existing parsing code for them really didn't follow the spec anyway given it enforced additional length restrictions that the BER spec technically allows.
davecgh
force-pushed
the
secp256k1_remove_ber_sig_support
branch
from
94bea06
to
ce39748
Compare
jrick
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #2095.
This removes the ability to parse signatures encoded with the more lax Basic Encoding Rules (BER) since they have never been valid on the Decred blockchain and the existing parsing code for them really didn't follow the spec anyway given it enforced additional length restrictions that the BER spec technically allows.