secp256k1: Rework DER sig parsing tests. #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
Feb 21, 2020
|
go.mod needs a 1.13 bump |
davecgh
force-pushed
the
secp256k1_der_sig_parsing_tests
branch
from
90705b9
to
4aef3f3
Compare
|
@dajohi Good call. Done. |
dajohi
approved these changes
Feb 21, 2020
This reworks the DER signature parsing tests to ensure 100% test coverage of all branches in the parsing code and also test for the explicit reason for a failure to ensure that each test is actually testing the intended condition. Compare this to the previous more generic validity testing which only tested that a signature failed to parse as opposed to _why_ it failed to parse. The result was that some of the tests were not actually testing what they claimed.
davecgh
force-pushed
the
secp256k1_der_sig_parsing_tests
branch
from
4aef3f3
to
b10c942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #2106.
This reworks the DER signature parsing tests to ensure 100% test coverage of all branches in the parsing code and also test for the explicit reason for a failure to ensure that each test is actually testing the intended condition.
Compare this to the previous more generic validity testing which only tested that a signature failed to parse as opposed to why it failed to parse. The result was that some of the tests were not actually testing what they claimed.