hdkeychain: Use secp256k1 privkey to pubkey method. #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Apr 5, 2020
matheusd
approved these changes
Apr 6, 2020
This makes use of the PubKey method on secp256k1.PrivateKey to convert a private key to a public key instead of manually performing the conversion. This is desirable since secp256k1 provides the method specifically for this purpose and it also has the benefit of allowing secp256k1 to perform the task without round tripping through big integers which results in slightly faster derivation. The following benchmarks show a before and after comparison of the affected operations: benchmark old ns/op new ns/op delta ---------------------------------------------------------- BenchmarkDeriveHardened 3702 3671 -0.84% BenchmarkDeriveNormal 4053 3999 -1.33% benchmark old allocs new allocs delta ---------------------------------------------------------- BenchmarkDeriveHardened 14 14 +0.00% BenchmarkDeriveNormal 15 15 +0.00% benchmark old bytes new bytes delta ---------------------------------------------------------- BenchmarkDeriveHardened 1360 1360 +0.00% BenchmarkDeriveNormal 1409 1409 +0.00%
davecgh
force-pushed
the
hdkeychain_use_secp2561_privkey_to_pubkey
branch
from
54916fe
to
79fa2f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #2155.
This makes use of the
PubKeymethod onsecp256k1.PrivateKeyto convert a private key to a public key instead of manually performing the conversion.This is desirable since
secp256k1provides the method specifically for this purpose and it also has the benefit of allowingsecp256k1to perform the task without round tripping through big integers which results in slightly faster derivation.The following benchmarks show a before and after comparison of the affected operations: