mining: Prevent potential shutdown hang. #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
May 5, 2020
dnldd
reviewed
May 8, 2020
davecgh
force-pushed
the
mining_prevent_potential_bgblktplgenerator_shutdown_hang
branch
from
96b2827
to
d6ab29b
Compare
dnldd
approved these changes
May 8, 2020
This modifies the background block template generator to ensure all regen even sends respect the context shutdown state to prevent a potential hang on shutdown when the underlying goroutines go away.
davecgh
force-pushed
the
mining_prevent_potential_bgblktplgenerator_shutdown_hang
branch
from
d6ab29b
to
94fd8fb
Compare
davecgh
deleted the
mining_prevent_potential_bgblktplgenerator_shutdown_hang
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #2195.
This modifies the background block template generator to ensure all regen even sends respect the context shutdown state to prevent a potential hang on shutdown when the underlying goroutines go away.