mempool/mining: Introduce TxSource interface. #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces the concept of a new interface named TxSource which aims to generically provide a concurrent safe source of transactions to be considered for inclusion in a new block. This is a step towards decoupling the mining code from the internals of btcd. Ultimately the intent is to create a separate mining package. The new TxSource interface relies on a new struct named miningTxDesc, which describes each entry in the transaction source. Once this code is refactored into a separate mining package, the mining prefix can simply be dropped leaving the type exported as mining.TxDesc. To go along with this, the existing TxDesc type in the mempool has been renamed to mempoolTxDesc and changed to embed the new miningTxDesc type. This allows the mempool to efficiently implement the MiningTxDescs method needed to satisfy the TxSource interface. This approach effectively separates the direct reliance of the mining code on the mempool and its data structures. Even though the memory pool will still be the default concrete implementation of the interface, making it an interface offers much more flexibility in terms of testing and even provides the potential to allow more than one source (perhaps multiple independent relay networks, for example). Finally, the memory pool and all of the mining code has been updated to implement and use the new interface.
davecgh
force-pushed
the
merge_introduce_txsource
branch
from
266ddbe
to
ac41800
Compare
|
tACK so far on testnet review looks good |
davecgh
force-pushed
the
merge_introduce_txsource
branch
from
ac41800
to
bfca3c2
Compare
Upstream commit 2b6a9a5. NOTE: This is only merging in the upstream changes, so while they are useful for Decred as well, this merge commit does fully separate the mempool as upstream does due to the new functionality provided by Decred.
davecgh
force-pushed
the
merge_introduce_txsource
branch
from
bfca3c2
to
9031d85
Compare
|
tACK. Have mined 10 blocks on testnet so far with this. |
|
utACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream commit 2b6a9a5.
NOTE: This is only merging in the upstream changes, so while they are useful for Decred as well, this merge commit does fully separate the mempool as upstream does due to the new functionality provided by Decred.