mempool: Move to internal. #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2020
rstaudt2
suggested changes
Jul 19, 2020
dnldd
approved these changes
Jul 19, 2020
davecgh
force-pushed
the
mempool_internal
branch
from
07c3486
to
3d59f75
Compare
|
Rebased and fixed the commit message typo pointed out by @rstaudt2. |
davecgh
force-pushed
the
mempool_internal
branch
from
3d59f75
to
a7adef7
Compare
rstaudt2
approved these changes
Jul 20, 2020
|
At the end of the file at |
|
Not completely sure, but in the commit message |
This makes the mempool an internal package such that it will no longer be an exported module. The only place its functionality is really needed is for the internal implementation of dcrd itself and thus having an unnecessary exported module significantly increases the maintenance burden. This is part of the overall effort to reduce the total number of modules and eventually get to the point it will be possible to follow semver for the root module. It is worth noting that there are a few constants, which will be listed below, that were exported from this module that callers might have previously relied upon. However, due to previous discussions about the goal of removing the module, a code search has revealed that there are no known callers that still rely on them. The aforementioned constants are: - MaxStandardTxSize - DefaultMinRelayTxFee - BaseStandardVerifyFlags Overview of the major changes: - Move the following files from mempool -> internal/mempool: - README.md - doc.go - error.go - log.go - mempool.go - mempool_test.go - policy.go - policy_test.go - Remove mempool/go.mod and mempool/go.sum - Make the README.md and doc.go files match the new reality - Update all import paths in the repository accordingly - Remove the dependency from the root go.mod - Run go mod tidy on all modules
davecgh
force-pushed
the
mempool_internal
branch
from
a7adef7
to
3e9c906
Compare
|
@JoeGruffins Regarding the Regarding the other one, it seems fine to me with or without the word where. |
JoeGruffins
approved these changes
Jul 20, 2020
davecgh
force-pushed
the
mempool_internal
branch
from
3e9c906
to
a524703
Compare
jrick
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #2273.
This makes the
mempoolan internal package such that it will no longer be an exported module. The only place its functionality is really needed is for the internal implementation of dcrd itself and thus having an unnecessary exported module significantly increases the maintenance burden.This is part of the overall effort to reduce the total number of modules and eventually get to the point it will be possible to follow semver for the root module.
It is worth noting that there are a few constants, which will be listed below, that were exported from this module that callers might have previously relied upon. However, due to previous discussions about the goal of removing the module, a code search has revealed that there are no known callers that still rely on them.
The aforementioned constants are:
MaxStandardTxSizeDefaultMinRelayTxFeeBaseStandardVerifyFlagsOverview of the major changes:
mempool->internal/mempool:README.mddoc.goerror.golog.gomempool.gomempool_test.gopolicy.gopolicy_test.gomempool/go.modandmempool/go.sumREADME.mdanddoc.gofiles match the new realitygo.modgo mod tidyon all modules