rpcserver: add missed and live tickets rpc tests. #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstaudt2
suggested changes
Jul 21, 2020
dnldd
force-pushed
the
add_missed_and_live_rpc_tests
branch
from
b6ac2d5
to
cc86c25
Compare
davecgh
requested changes
Jul 21, 2020
There was a problem hiding this comment.
In addition to the review, I confirmed full coverage for all three functions:
$ go test -run="TestHandle(Missed|Live)Tickets|TestHandleValidateAddress" -coverprofile=cov.out
$ go tool cover -func=cov.out | grep -E "handle(Missed|Live)Tickets|handleValidateAddress"
github.com/decred/dcrd/rpcserver.go:3550: handleLiveTickets 100.0%
github.com/decred/dcrd/rpcserver.go:3566: handleMissedTickets 100.0%
github.com/decred/dcrd/rpcserver.go:4730: handleValidateAddress 100.0%
This adds tests for the missed and live ticket rpcs as well as the validate address rpc.
dnldd
force-pushed
the
add_missed_and_live_rpc_tests
branch
from
cc86c25
to
efa4931
Compare
davecgh
approved these changes
Jul 21, 2020
rstaudt2
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for the missed and live ticket rpcs as well as the validate address rpc.
Work towards #2069.