rpcserver: add verifychain & getdifficulty tests. #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Jul 21, 2020
dnldd
force-pushed
the
add_verify_and_getdiff_tests
branch
from
39df38e
to
cf2089f
Compare
davecgh
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
In addition to the review, I confirmed full coverage for both functions after the latest update:
$ go test -run="TestHandle(GetDifficulty|VerifyChain)" -coverprofile=cov.out
$ go tool cover -func=cov.out | grep -E "handle(GetDifficulty|VerifyChain)"
github.com/decred/dcrd/rpcserver.go:2164: handleGetDifficulty 100.0%
github.com/decred/dcrd/rpcserver.go:4780: handleVerifyChain 100.0%
rstaudt2
suggested changes
Jul 22, 2020
dnldd
force-pushed
the
add_verify_and_getdiff_tests
branch
from
cf2089f
to
33df382
Compare
This adds rpc tests for the verifychain and getdifficulty rpcs.
dnldd
force-pushed
the
add_verify_and_getdiff_tests
branch
from
33df382
to
aa4ae0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds rpc tests for the
verifychainandgetdifficultyrpcs.Work towards #2069.