peer: Rename variable for consistency. #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation of moving mempool to its own subpackage. No functional change.
This creates a skeleton mining package that simply contains a few of the definitions used by the mining and mempool code. This is a step towards decoupling the mining code from the internals of btcd and ultimately will house all of the code related to creating block templates and CPU mining. The main reason a skeleton package is being created before the full blown package is ready is to avoid blocking mempool separation which relies on these type definitions.
DisableRelayTx sets the DisableRelayTx value in the version message which informs the remote peer on whether to send inv messages for transactions.
The CPU miner relies on the mempool, so the mempool has to be created before calling the function to create the CPU miner. When PR btcsuite#568 introduced the mempool config struct, it moved the mempool creation after the miner creation, which leads to the CPU miner crashing due to trying to access a nil mempool. This move the CPU miner creation after the mempool creation appropriately.
In case of an error during protocol negotiation in handleVersionMsg, immediately break out and prevent further processing of OnVersion listener which generally depends upon peer attributes like NA to be set during the negotiation. Fixes btcsuite#579.
|
OK |
Contains the following upstream commits: - 83bcfea - 2f6aeac - Cherry-picked because it fixes an issue originally introduced by the commit being merged In addition to the normal required changes for syncing, the following changes have been made in order to facilitate integration into Decred: - Configure the NewestSha function to the new mempool config as a closure over the block manager state instead of using the database func directly - Add a new NextStakeDifficulty callback to the new mempool config for obtaining the next stake difficulty from the block manager and configure it as a closure over the block manager state.
|
Once 227 and 228 are in this one is really very little so nothing controversial at all. |
davecgh
force-pushed
the
merge_peer-rename
branch
from
5f0b46a
to
08f7b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the following upstream commits: