rpcserver: Add handleSearchRawTransactions tests. #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
added
the
test coverage
JoeGruffins
approved these changes
Aug 21, 2020
rstaudt2
force-pushed
the
search-raw-transactions-tests
branch
from
f6fcb87
to
8721cbf
Compare
rstaudt2
force-pushed
the
search-raw-transactions-tests
branch
from
8721cbf
to
2c286e2
Compare
This adds an AddrIndexer interface to rpcserver, which decouples rpcserver from the implementation of the address index and allows a mocked version to be provided for testing.
This adds a TxIndexer interface to rpcserver, which decouples rpcserver from the implementation of the transaction index and allows a mocked version to be provided for testing.
This adds testDB and testDatabaseTx structs that provide mock implementations of the database.DB and database.Tx interfaces for testing purposes.
rstaudt2
force-pushed
the
search-raw-transactions-tests
branch
from
2c286e2
to
1c4c171
Compare
davecgh
approved these changes
Aug 30, 2020
There was a problem hiding this comment.
$ go test -run="TestHandleSearchRawTransactions" -coverprofile=cov.out
$ go tool cover -func=cov.out | grep -E "handleSearchRawTransactions|fetchMempoolTxnsForAddress"
github.com/decred/dcrd/internal/rpcserver/rpcserver.go:3868: fetchMempoolTxnsForAddress 100.0%
github.com/decred/dcrd/internal/rpcserver/rpcserver.go:3887: handleSearchRawTransactions 99.2%
I also confirmed that the uncovered branch is not reachable currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds test coverage for
handleSearchRawTransactionsandfetchMempoolTxnsForAddress.There is one error case here that is unreachable, and the rest of these functions are covered:
Part of #2069.