multi: Add initialstate peer messages. #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
changed the title
matheusd
force-pushed
the
initialstatemsg
branch
from
efe39e7
to
4204cb1
Compare
jrick
reviewed
Sep 3, 2020
jrick
approved these changes
Sep 3, 2020
dnldd
suggested changes
Sep 4, 2020
dnldd
approved these changes
Sep 5, 2020
matheusd
force-pushed
the
initialstatemsg
branch
2 times, most recently
from
a42b2ac
to
aceef3f
Compare
davecgh
requested changes
Sep 23, 2020
davecgh
requested changes
Sep 23, 2020
davecgh
approved these changes
Sep 23, 2020
marcopeereboom
approved these changes
Sep 23, 2020
This adds the GetInitState and InitState messages along with appropriate tests. It also adds a new protocol version (version 8) and bumps the current wire version to it. This set of messages will be used to allow peers to exchange ephemeral startup information in a more general manner than the current existing GetMiningState/MiningState pair. In particular, peers will be able to selectively request only the specific startup info they're insterested in so that different types of nodes (such as SPV clients) may only request relevant startup information. Compared to the existing MiningState message, the InitState message already offers a new type of data: tspend hashes, that nodes may use to fetch tspend transactions for inspecting, generating templates and voting on their approval.
This modifies the peer package to handle GetInitState/InitState messages by adding the appropriate listeners. It also bumps the max supported protocol version to version 8, which is needed to be able to decode the messages. Note this modifies the peer package's go.mod to use the local copy of the wire module in order to have access to the new messages.
This changes the server to support the most recent protocol version (v8 or InitStateVersion). On this version, instead of using the getminingstate/miningstate pair of messages, peers use getinitstate/initstate messages which allow for finer grained control over what information is sent upon startup. The older protocol versions are still supported so that the node may continue to both request and serve initial mining state to older nodes of the network.
matheusd
force-pushed
the
initialstatemsg
branch
from
813b816
to
cf277fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on top of
#2170#2350Includes #2348This is part of the treasury decentralization work.
This adds a new pair of messages to the peer protocol named
getinitstate/initstate. These messages are meant to be used as replacements for thegetminingstate/miningstatemessages.The new messages are more generic and meant to be used for both the existing mining information (head blocks and votes) and other ephemeral data that nodes of the peer network might need. The initial implementation in dcrd additionally offers and responds with treasury spend transactions.
tpends are special transactions in that they are meant to be long-lived in the mempool and not only miner nodes but also voting wallet nodes need to discover them in a timely manner. Thus we introduce this new set of messages in order to relay them in the network as nodes startup.
This work isn't strictly consensus-related and thus has been extracted from the main treasury PR to ease review by external developers.