Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chaincfg: Add checkpoints for upcoming release. #2370

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Sep 24, 2020

This adds checkpoints at the following heights:

mainnet:

  • 237310
  • 277940
  • 318020
  • 340120
  • 362120
  • 404170
  • 424170
  • 444170
  • 464170
  • 483600

testnet:

  • 148320
  • 213120
  • 347140
  • 411940
  • 476740
  • 515730

Note that this also includes some historical checkpoints to limit the size of the gaps between each checkpoint to be around 3 months max. This is being done because recent optimizations have sped up processing to the point that larger gaps can trigger peers to get banned during IBD in some cases.

@davecgh davecgh added this to the 1.6.0 milestone Sep 24, 2020
@davecgh
Copy link
Member Author

davecgh commented Sep 24, 2020

$ for height in 237310 277940 318020 340120 362120 404170 424170 444170 464170 483600; do hash=$(dcrctl getblockhash $height); echo "height: $height, hash: $hash"; done
height: 237310, hash: 000000000000000a6815e366425acd30354dfdcb55f401e38b037e87ca00f171
height: 277940, hash: 000000000000000043b47c777bc96760e6fccc872cc8edb295b230dd8dd0f5d7
height: 318020, hash: 00000000000000002765c601fe4455126ab27913fcc2d2db28f78e1e6bb77266
height: 340120, hash: 00000000000000001a9ba30acfd8272aa1514ce7979fc508118ee3764a19df46
height: 362120, hash: 00000000000000000219580063387071893bcd0992cacb5f0aa55fc9e6c4a0ab
height: 404170, hash: 000000000000000010352022d88733bac2665c882030db071ce5ea29970fefd8
height: 424170, hash: 00000000000000000b8526a9fdd31fcb249c992fc0741d422528ce2fa975bbd0
height: 444170, hash: 00000000000000000673a109a997e8ca41bc4ece86445bc89c1bb2b9921633cc
height: 464170, hash: 0000000000000000063c4588ffa1ff25978c025eaf529f39bcbad8b962502f65
height: 483600, hash: 000000000000000010f98f7354b501b5747011c82d53b989dbcb368e5059ff9e

$ for height in 148320 213120 347140 411940 476740 515730; do hash=$(dcrctl --testnet getblockhash $height); echo "height: $height, hash: $hash"; done
height: 148320, hash: 0000000003535b80e4b759b8ec1790f81f429d9f5a810eda43c3afb64d9760b1
height: 213120, hash: 000000000009bb6909db742278f3ab7c9169ef396068cce7f750b587b72738af
height: 347140, hash: 0000001638f00f197b882a00db04d1323e205f45bf1108e4f1bbc1f456d4250c
height: 411940, hash: 00000012b6d21f31f18a2f6d8b64e111327f011ac13a1b3e9d0d8b477f71f62b
height: 476740, hash: 00000005635a4b783ad4d85e0cb92f094e2e885a92ef4d6b8464b22a02646279
height: 515730, hash: 00000010ecddf8da5d91f7020f69130db8a163906d460cbbed2a91568701f0ac

@degeri
Copy link
Member

degeri commented Sep 24, 2020

Matches

$ for height in 237310 277940 318020 340120 362120 404170 424170 444170 464170 483600; do hash=$(dcrctl getblockhash $height); echo "height: $height, hash: $hash"; done
height: 237310, hash: 000000000000000a6815e366425acd30354dfdcb55f401e38b037e87ca00f171
height: 277940, hash: 000000000000000043b47c777bc96760e6fccc872cc8edb295b230dd8dd0f5d7
height: 318020, hash: 00000000000000002765c601fe4455126ab27913fcc2d2db28f78e1e6bb77266
height: 340120, hash: 00000000000000001a9ba30acfd8272aa1514ce7979fc508118ee3764a19df46
height: 362120, hash: 00000000000000000219580063387071893bcd0992cacb5f0aa55fc9e6c4a0ab
height: 404170, hash: 000000000000000010352022d88733bac2665c882030db071ce5ea29970fefd8
height: 424170, hash: 00000000000000000b8526a9fdd31fcb249c992fc0741d422528ce2fa975bbd0
height: 444170, hash: 00000000000000000673a109a997e8ca41bc4ece86445bc89c1bb2b9921633cc
height: 464170, hash: 0000000000000000063c4588ffa1ff25978c025eaf529f39bcbad8b962502f65
height: 483600, hash: 000000000000000010f98f7354b501b5747011c82d53b989dbcb368e5059ff9e

$ for height in 148320 213120 347140 411940 476740 515730; do hash=$(dcrctl --testnet getblockhash $height); echo "height: $height, hash: $hash"; done
height: 148320, hash: 0000000003535b80e4b759b8ec1790f81f429d9f5a810eda43c3afb64d9760b1
height: 213120, hash: 000000000009bb6909db742278f3ab7c9169ef396068cce7f750b587b72738af
height: 347140, hash: 0000001638f00f197b882a00db04d1323e205f45bf1108e4f1bbc1f456d4250c
height: 411940, hash: 00000012b6d21f31f18a2f6d8b64e111327f011ac13a1b3e9d0d8b477f71f62b
height: 476740, hash: 00000005635a4b783ad4d85e0cb92f094e2e885a92ef4d6b8464b22a02646279
height: 515730, hash: 00000010ecddf8da5d91f7020f69130db8a163906d460cbbed2a91568701f0ac

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Also checked those were in fact checkpoint candidates as returned by IsCheckpointCandidate().

@davecgh
Copy link
Member Author

davecgh commented Sep 24, 2020

@matheusd Thanks for also verifying via IsCheckpointCandidate(). I did as well before creating the PR. I probably should've called that out.

Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches

Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - same output as everybody else

This adds checkpoints at the following heights:

mainnet:

- 237310
- 277940
- 318020
- 340120
- 362120
- 404170
- 424170
- 444170
- 464170
- 483600

testnet:

- 148320
- 213120
- 347140
- 411940
- 476740
- 515730

Note that this also includes some historical checkpoints to limit the
size of the gaps between each checkpoint to be around 3 months max.
This is being done because recent optimizations have sped up processing
to the point that larger gaps can trigger peers to get banned during IBD
in some cases.
@davecgh davecgh merged commit 1d134a2 into decred:master Sep 25, 2020
@davecgh davecgh deleted the checkpoint branch September 25, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants