rpcserver: Forward HTTP server err msgs to logger. #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
rpcserver_provide_error_logger
branch
from
9d92188
to
e44b58c
Compare
|
LGTM. Getting logged by our logger in the right format and location. |
dajohi
approved these changes
Sep 25, 2020
The standard library HTTP server writes all errors using standard error by default when and error logger is not configured. Currently, an error logger is not being set which means the errors completely bypass the logging system. Since the required error logger must be from the standard library logging package and a custom logger is used instead, this creates a shim to forward the log messages from a standard lib logger to the RPC server logger and configures the HTTP server to use it accordingly.
davecgh
force-pushed
the
rpcserver_provide_error_logger
branch
from
e44b58c
to
1e44e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard library HTTP server writes all errors using standard error by default when and error logger is not configured. Currently, an error logger is not being set which means the errors completely bypass the logging system.
Since the required error logger must be from the standard library logging package and a custom logger is used instead, this creates a shim to forward the log messages from a standard lib logger to the RPC server logger and configures the HTTP server to use it accordingly.