Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: add ticketvwap tests. #2406

Merged
merged 1 commit into from Oct 26, 2020
Merged

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented Oct 7, 2020

This adds rpc tests for ticketvwap.

Work towards #2069.

@dnldd
Copy link
Member Author

dnldd commented Oct 7, 2020

go tool cover -func=cov.out | grep -E handleTicketVWAP
github.com/decred/dcrd/internal/rpcserver/rpcserver.go:4996:              handleTicketVWAP                100.0%

@davecgh davecgh added the test coverage Discussion and pull requests for improving test coverage. label Oct 7, 2020
@davecgh davecgh added this to the 1.7.0 milestone Oct 7, 2020
Copy link
Member

@rstaudt2 rstaudt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage looks good, just had a couple of very minor stylistic comments.

internal/rpcserver/rpcserverhandlers_test.go Outdated Show resolved Hide resolved
internal/rpcserver/rpcserverhandlers_test.go Outdated Show resolved Hide resolved
internal/rpcserver/rpcserverhandlers_test.go Outdated Show resolved Hide resolved
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with all of @rstaudt2's review comments. Otherwise, looks good.

@davecgh
Copy link
Member

davecgh commented Oct 26, 2020

Approved, but needs a rebase to resolve the merge conflict before I can merge.

This adds rpc tests for ticketvwap.
@davecgh davecgh merged commit 71c0289 into decred:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test coverage Discussion and pull requests for improving test coverage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants