-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpcserver: add ticketvwap tests. #2406
Conversation
go tool cover -func=cov.out | grep -E handleTicketVWAP
github.com/decred/dcrd/internal/rpcserver/rpcserver.go:4996: handleTicketVWAP 100.0% |
158d80f
to
852d0ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test coverage looks good, just had a couple of very minor stylistic comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with all of @rstaudt2's review comments. Otherwise, looks good.
852d0ac
to
b779899
Compare
Approved, but needs a rebase to resolve the merge conflict before I can merge. |
This adds rpc tests for ticketvwap.
b779899
to
beff172
Compare
This adds rpc tests for
ticketvwap
.Work towards #2069.