dcrjson: Reject dup method type registrations. #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
Oct 13, 2020
davecgh
force-pushed
the
dcrjson_reject_duplicate_method_type_registrations
branch
2 times, most recently
from
973c5b8
to
202a8f0
Compare
dnldd
approved these changes
Oct 15, 2020
This modifies the registration function to return an error as expected in the case the same method type is registered more than once and adds code to return an error when the parameter type is already registered for some other method type. The current code allowed the same method type to be registered again so long as it had the same parameter type associated with it, which is not desirable since it might have been registered with a different set of flags and the new registration would simply be ignored.
davecgh
force-pushed
the
dcrjson_reject_duplicate_method_type_registrations
branch
from
202a8f0
to
64b4404
Compare
davecgh
deleted the
dcrjson_reject_duplicate_method_type_registrations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the registration function to return an error as expected in the case the same method type is registered more than once and adds code to return an error when the parameter type is already registered for some other method type.
The current code allowed the same method type to be registered again so long as it had the same parameter type associated with it, which is not desirable since it might have been registered with a different set of flags and the new registration would simply be ignored.