mining: Split into separate files. #2431
Conversation
This moves txPriorityQueue and the related logic to a separate file, mining/txpriorityqueue.go. Additionally, it moves the txPriorityQueue tests to mining/txpriorityqueue_tests.go. This is part of an effort to split mining into several files to make the package easier to navigate, and in preparation of adding additional test coverage.
This includes some minor cleanup for the txPriorityQueue tests and additionally improves the test coverage to 100% for txpriorityqueue.go.
This moves the interfaces that are defined by mining to a separate file, mining/interface.go. This is part of an effort to split mining into several files to make the package easier to navigate, and in preparation of adding additional test coverage.
There was a problem hiding this comment.
Thanks for the PR and, as I often mention, I really appreciate that you split the changes up into well crafted and easier to review commits. It makes the review significantly easier and speeds the process up as a result.
Nice change to the priority queue tests to only create the random items once!
One thing I noticed is that the blockManagerFacade is really a pretty poorly named interface and has at least one method on it that probably should either be its own interface or reworked entirely. Namely, the NotifyWork(templateNtfn *TemplateNtfn). If it is to be kept, it probably should be part of something like type WorkNotifier interface { ... }. However, looking at its purpose, all it really does is call the NotifyWork func on the block manager which in turn forwards it to the rpcserver.NotifyWork method if the rpcserver is active, so I suspect the RPC server should just subscribe for work notifications like everything else and then there would be no need for the delegation at all.
I know it was obviously already named it and hence I don't think it's appropriate to change it this PR, but I figured I'd mention it while here.
This moves BgBlkTmplGenerator and the related logic to a separate file, mining/bgblktmplgenerator.go. This is part of an effort to split mining into several files to make the package easier to navigate, and in preparation of adding additional test coverage.
rstaudt2
force-pushed
the
spilt-mining-to-separate-files
branch
from
44cea34
to
0977e2b
Compare
|
Thanks for the reviews. I updated the copyright as suggested in |
This splits the mining package into a few additional files to make the package easier to navigate. It also cleans up some tests and comments along the way.
This is split into separate commits so that it is easy to verify that things did not change as they were moved.