blockchain: Make ver 5 to 6 db upgrades work again. #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
added
database upgrade
matheusd
approved these changes
Oct 23, 2020
davecgh
force-pushed
the
blockchain_correct_v5_to_v6_upgrade
branch
from
2370d61
to
822c6d4
Compare
davecgh
force-pushed
the
blockchain_correct_v5_to_v6_upgrade
branch
from
822c6d4
to
16ed00c
Compare
dnldd
approved these changes
Oct 26, 2020
matheusd
approved these changes
Oct 26, 2020
This allows version 5 to 6 database upgrades to work again by implementing code that is independent of the main code and works with the data structures as they existed in the version 5 database. While here, it also updates some other cases in both older and newer upgrade code to make the upgrades stable even if the primary code changes. An high-level overview of the key changes is: - Clear the failed validation status of the v2 block index entries directly instead of loading the code into the main index, modifying it, and flushing it - Avoid using the unversioned main funcs related to serializing and deserializing the spend journal - Implement code to directly create a script source from a v2 spend journal entry - Reimplement the migration code that initializes the v2 GCS filters to independently read the block tree and discover the main chain
davecgh
force-pushed
the
blockchain_correct_v5_to_v6_upgrade
branch
from
16ed00c
to
c1d3c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows version 5 to 6 database upgrades to work again by implementing code that is independent of the main code and works with the data structures as they existed in the version 5 database.
While here, it also updates some other cases in both older and newer upgrade code to make the upgrades stable even if the primary code changes.
A high-level overview of the key changes is: