config: Use the P-256 curve by default for RPC. #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Nov 4, 2020
dnldd
approved these changes
Nov 4, 2020
jrick
approved these changes
Nov 4, 2020
This modifies the default curve used to generate the RPC certificates to be P-256 instead of P-521. While I very much prefer the stronger curve, unfortunately, Chromium removed support for P-521 and since that is what electron uses under the hood, Decrediton can no longer connect to dcrd RPC servers using a certificate with P-521.
davecgh
force-pushed
the
config_change_default_rpc_cert_curve
branch
from
88a1cdf
to
dfafa02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the default curve used to generate the RPC certificates to be P-256 instead of P-521. While I very much prefer the stronger curve, unfortunately, Chromium removed support for P-521 and since that is what electron uses under the hood, Decrediton can no longer connect to dcrd RPC servers using a certificate with P-521.