[release-v1.6] rpcserver: Correct treasury vote status handling. #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects several of the RPC handlers to base the status of whether or not the decentralized treasury rules are active based on the location of the element in question versus whatever the current tip happens to be. In particular, the following RPCs are corrected: - getblock - getblocksubsidy - getrawtransaction - gettxout - rescan - searchrawtransactions - ticketfeeinfo - txfeeinfo While here, it also modifies searchrawtransaction to use the height in the header instead of performing another lookup from chain since it is already available there and removes a TODO that no longer applies.
jrick
approved these changes
Nov 23, 2020
dajohi
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #2469 to the 1.6 release branch.