Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcserver: Add handleGetMempoolInfo test. #2492

Merged
merged 1 commit into from Dec 9, 2020
Merged

rpcserver: Add handleGetMempoolInfo test. #2492

merged 1 commit into from Dec 9, 2020

Conversation

JoeGruffins
Copy link
Member

Part of #2069

@JoeGruffins
Copy link
Member Author 

$ go test -run="TestHandleGetMempoolInfo" -coverprofile=cov.out && go tool cover -func=cov.out | grep -E "handleGetMempoolInfo"
PASS
coverage: 0.4% of statements
ok      github.com/decred/dcrd/internal/rpcserver       0.030s
github.com/decred/dcrd/internal/rpcserver/rpcserver.go:2496:            handleGetMempoolInfo            100.0%

davecgh
davecgh requested changes Dec 8, 2020
View reviewed changes
internal/rpcserver/rpcserverhandlers_test.go Outdated Show resolved Hide resolved
internal/rpcserver/rpcserverhandlers_test.go Outdated Show resolved Hide resolved
internal/rpcserver/rpcserverhandlers_test.go Outdated Show resolved Hide resolved
internal/rpcserver/rpcserverhandlers_test.go Show resolved Hide resolved
@davecgh davecgh added this to the 1.7.0 milestone Dec 8, 2020
@davecgh davecgh added the test coverage Discussion and pull requests for improving test coverage. label Dec 8, 2020
rstaudt2
rstaudt2 approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@rstaudt2 rstaudt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just had one very minor suggestion.

internal/rpcserver/rpcserverhandlers_test.go Show resolved Hide resolved
@davecgh davecgh merged commit d09e492 into decred:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecgh davecgh davecgh approved these changes

@dnldd dnldd dnldd approved these changes

@rstaudt2 rstaudt2 rstaudt2 approved these changes

Assignees
No one assigned
Labels
test coverage Discussion and pull requests for improving test coverage.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JoeGruffins @dnldd @rstaudt2 @davecgh