multi: Use best state snapshot next stake diff. #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
approved these changes
Dec 9, 2020
rstaudt2
approved these changes
Dec 10, 2020
davecgh
force-pushed
the
multi_use_best_state_snapshot_next_stake_diff
branch
from
da48c4b
to
53f521c
Compare
The current best state snapshot was updated a long time ago to include the next required stake difficulty. This updates the RPC server to make use of that versus making an explicit call. It also removes the no longer used method from the rpcserver.Chain interface and related test code accordingly.
This removes unused code related to calculating the next required stake difficulty through the block manager.
This updates the broadcast pruning logic in server to make use of the next required stake difficulty from the best state snapshot versus making an explicit call.
davecgh
force-pushed
the
multi_use_best_state_snapshot_next_stake_diff
branch
from
53f521c
to
ad0a2fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current best state snapshot was updated a long time ago to include the next required stake difficulty. This updates the RPC server, block manager, and broadcast pruning logic in server to make use of that versus making an explicit call.
It also removes the no longer used method from the
rpcserver.Chaininterface, the block manager infrastructure, and related test code accordingly.